Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: remove v1alpha3 #75179

Merged
merged 1 commit into from Mar 23, 2019

Conversation

@rosti
Copy link
Member

commented Mar 8, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Remove deprecated old v1alpha3 kubeadm config.

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1296

Special notes for your reviewer:

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/priority important-longterm
/assign @luxas
/assign @fabriziopandini

This is for 1.15!
/hold

Does this PR introduce a user-facing change?:

kubeadm: Support for deprecated old kubeadm v1alpha3 config is totally removed.
kubeadm: remove v1alpha3
Remove deprecated old v1alpha3 kubeadm config.

Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
@neolit123
Copy link
Member

left a comment

/lgtm
/approve

@neolit123

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

/assign @fejta
for hack/.golint_failures :)

@rosti

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

/hold cancel

@dixudx

dixudx approved these changes Mar 21, 2019

@fejta

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, neolit123, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9c53f24 into kubernetes:master Mar 23, 2019

17 checks passed

cla/linuxfoundation rosti authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.