Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cluster Autscaler version to 1.14.0-beta.1 #75181

Merged
merged 1 commit into from Mar 11, 2019

Conversation

@losipiuk
Copy link
Contributor

losipiuk commented Mar 8, 2019

This PR updates CA version in gce manifests to 1.14.0-beta.1

We need to merge it during freeze because, Cluster Autoscaler imports large amount of k8s code to simulate scheduler behavior, yet it lives in separate repository. Therefore
we need to build final release candidate just at the end of k8s release cycle.

NONE
@losipiuk

This comment has been minimized.

Copy link
Contributor Author

losipiuk commented Mar 8, 2019

/kind bug
/priority critical-urgent

@losipiuk

This comment has been minimized.

Copy link
Contributor Author

losipiuk commented Mar 8, 2019

/assign @mwielgus

@mwielgus
Copy link
Contributor

mwielgus left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mwielgus mwielgus added this to the v1.14 milestone Mar 11, 2019

@k8s-ci-robot k8s-ci-robot merged commit 6ec5a7d into kubernetes:master Mar 11, 2019

17 checks passed

cla/linuxfoundation losipiuk authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Mar 11, 2019

FYI no cherry pick into release-1.14 will be necessary, we do daily ffwds of master into release-1.14 during code freeze. Cherry picks are only necessary after code thaw

@losipiuk

This comment has been minimized.

Copy link
Contributor Author

losipiuk commented Mar 11, 2019

FYI no cherry pick into release-1.14 will be necessary, we do daily ffwds of master into release-1.14 during code freeze. Cherry picks are only necessary after code thaw

Yeah. I noticed that after sending out PR. Thanks for looking :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.