Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow different operation names #75213
Allow different operation names for different storage operations. This still prevents two operations on same volume from happening concurrently but if operation changes, it resets the exponential backoff.
Mar 8, 2019
@jsafrane agreed about getting more eyes on the PR. In general, I think this PR works and isn't breaking.
Obviously this PR currently does not affect attach/detach yet because I haven't put a name to those operations yet. We could this incrementally I guess since mount/unmount was the one that @smarterclayton reported as immediate problem.
Mar 12, 2019
bertinatto left a comment •
@gnufied, it seems like it does affect attach/detach operations. Even though
I guess if we only want to cover mount/unmount operations we should make
Also, it might be worth adding a test to simulate attach/detach operations (if we want them to have a different treatment, of course).
@bertinatto what I meant was for attach/detach operations this PR does not changes old behaviour. Since both attach and detach do not specify
Mar 13, 2019
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing