Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disable outbound snat when Azure standard load balancer is used #75282

Merged
merged 1 commit into from Mar 13, 2019

Conversation

@feiskyer
Copy link
Member

commented Mar 12, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:

Azure outbound rules are not taking effect when used together with standard load balancer .

This PR adds a new configuration for disabling SNAT for load balancer rules, so that outbound rules would be used as the egress IPs.

In such case, disableOutboundSNAT should be set to true and loadBalancerSku should be set to standard.

Which issue(s) this PR fixes:

Fixes #75281

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Allow disable outbound SNAT when Azure standard load balancer is used together with outbound rules. 
@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

Added to v1.14 since it is a critical bug fix.

/kind bug
/sig azure
/milestone v1.14
/priority critical-urgent

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer feiskyer added this to In progress in SIG Azure via automation Mar 12, 2019

@feiskyer feiskyer force-pushed the feiskyer:disable-outboud-snat branch from 98b8573 to 84617c8 Mar 13, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@andyzhangx
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 13, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

/retest

1 similar comment
@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

/retest

@feiskyer feiskyer moved this from In progress to Needs Review in SIG Azure Mar 13, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Mar 13, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 815086f into kubernetes:master Mar 13, 2019

18 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

SIG Azure automation moved this from Needs Review to Done Mar 13, 2019

@feiskyer feiskyer deleted the feiskyer:disable-outboud-snat branch Mar 13, 2019

k8s-ci-robot added a commit that referenced this pull request Mar 14, 2019

Merge pull request #75331 from feiskyer/automated-cherry-pick-of-#752…
…82-upstream-release-1.12

Automated cherry pick of #75282: Allow disable outbound snat when Azure standard load balancer

k8s-ci-robot added a commit that referenced this pull request Mar 19, 2019

Merge pull request #75332 from feiskyer/automated-cherry-pick-of-#752…
…82-upstream-release-1.13

Automated cherry pick of #75282: Allow disable outbound snat when Azure standard load balancer

k8s-ci-robot added a commit that referenced this pull request Mar 21, 2019

Merge pull request #75333 from feiskyer/automated-cherry-pick-of-#752…
…82-upstream-release-1.11

Automated cherry pick of #75282: Allow disable outbound snat when Azure standard load balancer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.