Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[kube-proxy/ipvs] Do not delete existing VS and RS when starting #75283
What type of PR is this?
What this PR does / why we need it:
I tested several cases to make sure this did not break anything:
=> Everything was successfully resynced as soon as syncProxyRules ran
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
Hi @lbernail. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
@lbernail -- thanks for this bugfix!
It seems from a slack convo with @lbernail that this is not super urgent. My gut feeling is to not bring it into 1.14 that late. But I'll defer this to the leads of SIG-network. If we'd not include that in 1.14 that potentially also give us some time to have some tests for this issue?