Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-proxy/ipvs] Do not delete existing VS and RS when starting #75283

Merged
merged 1 commit into from Mar 20, 2019

Conversation

@lbernail
Copy link
Contributor

commented Mar 12, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Avoid graceful deletion of RS when starting the GracefulTerminationManager. By doing this, we were removing RS that had no Active/Inactive connections and setting the weight of the others to 0. This means no connection could be established until syncProxyRules ran for the first time.

I tested several cases to make sure this did not break anything:

  • turn off kube-proxy
  • delete a service
  • delete an endpoint on another service
  • restart kube-proxy

=> Everything was successfully resynced as soon as syncProxyRules ran

However, I don't have the initial context for this behavior at start-up so I may be missing something. @Lion-Wei / @m1093782566 you may have some insights?

Which issue(s) this PR fixes:
Fixes #73154

Does this PR introduce a user-facing change?:

[IPVS] Allow for transparent kube-proxy restarts

/assign @m1093782566
/sig network
/area ipvs

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Hi @lbernail. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@m1093782566

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

/ok-to-test

@m1093782566

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 12, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernail, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lbernail

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

/test pull-kubernetes-integration

@lbernail

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

/assign @hoegaarden

@hoegaarden

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

Hey all.

@lbernail -- thanks for this bugfix!

It seems from a slack convo with @lbernail that this is not super urgent. My gut feeling is to not bring it into 1.14 that late. But I'll defer this to the leads of SIG-network. If we'd not include that in 1.14 that potentially also give us some time to have some tests for this issue?

@kubernetes/sig-network-bugs
@kubernetes/sig-network-pr-reviews

@k8s-ci-robot k8s-ci-robot merged commit 88dc966 into kubernetes:master Mar 20, 2019

17 checks passed

cla/linuxfoundation lbernail authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
k8s-ci-robot added a commit that referenced this pull request Mar 27, 2019
Merge pull request #75723 from DataDog/automated-cherry-pick-of-#7528…
…3-upstream-release-1.12

Automated cherry pick of #75283 upstream release 1.12
k8s-ci-robot added a commit that referenced this pull request Apr 4, 2019
Merge pull request #75721 from DataDog/automated-cherry-pick-of-#7528…
…3-upstream-release-1.14

Automated cherry pick of #75283 upstream release 1.14
k8s-ci-robot added a commit that referenced this pull request Apr 4, 2019
Merge pull request #75722 from DataDog/automated-cherry-pick-of-#7528…
…3-upstream-release-1.13

Automated cherry pick of #75283 upstream release 1.13
@lbernail lbernail referenced this pull request May 13, 2019
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.