Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #75073: Allow session affinity a period of time to setup for new #75341

Conversation

@grayluck
Copy link
Contributor

grayluck commented Mar 13, 2019

Cherry pick of #75073 on release-1.13.

#75073: Allow session affinity a period of time to setup for new

Allow session affinity a period of time to setup for new services.
This is to deal with the flaky session affinity test.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 13, 2019

@grayluck: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #75073.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 13, 2019

@grayluck: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 13, 2019

Hi @grayluck. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grayluck

This comment has been minimized.

Copy link
Contributor Author

grayluck commented Mar 13, 2019

/sig network
/sig testing
/priority important-soon
/kind flake
/assign @MrHohn

@MrHohn

MrHohn approved these changes Mar 13, 2019

Copy link
Member

MrHohn left a comment

/ok-to-test
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grayluck, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grayluck

This comment has been minimized.

Copy link
Contributor Author

grayluck commented Mar 13, 2019

Thanks MrHohn :D
Assigning patch release manager for cherrypick approval.
/assign @aleksandra-malinowska @tpepper

@schoolteacher1

This comment has been minimized.

Copy link

schoolteacher1 commented Mar 13, 2019

Life is good

@grayluck

This comment has been minimized.

Copy link
Contributor Author

grayluck commented Mar 13, 2019

/retest

1 similar comment
@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 14, 2019

/retest

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 14, 2019

pull-kubernetes-integration's failed run seems to be a flake (related: #72493)

/retest

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 14, 2019

(talking about #48680)

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 14, 2019

@aleksandra-malinowska / @tpepper , are you happy to merge this to 1.13? 🙏

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 14, 2019

@grayluck it looks like the PR also needs a release note (it could be none if you feel it's not applicable, I'll leave that to you)

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Mar 14, 2019

(Checking if this still work.)
/release-note-none

@k8s-ci-robot k8s-ci-robot merged commit 110766c into kubernetes:release-1.13 Mar 14, 2019

16 of 17 checks passed

tide Not mergeable.
Details
cla/linuxfoundation grayluck authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.