Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #75087: fix smb unmount issue on Windows #75359

Open
wants to merge 1 commit into
base: release-1.12
from

Conversation

@andyzhangx
Copy link
Member

andyzhangx commented Mar 14, 2019

Cherry pick of #75087 on release-1.12.

#75087: fix smb unmount issue on Windows

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 14, 2019

@andyzhangx: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx

This comment has been minimized.

Copy link
Member Author

andyzhangx commented Mar 14, 2019

/kind bug
/assign @jingxu97
/priority important-soon
/sig windows
/pull-kubernetes-cross test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 14, 2019

@andyzhangx: GitHub didn't allow me to assign the following users: jingxu.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/kind bug
/assign @jingxu
/priority important-soon
/sig windows
/pull-kubernetes-cross test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx

This comment has been minimized.

Copy link
Member Author

andyzhangx commented Mar 14, 2019

/assign @jingxu97

@andyzhangx andyzhangx force-pushed the andyzhangx:automated-cherry-pick-of-#75087-upstream-release-1.12 branch from 829fff4 to 3a64ea3 Mar 14, 2019

@andyzhangx andyzhangx force-pushed the andyzhangx:automated-cherry-pick-of-#75087-upstream-release-1.12 branch from 3a64ea3 to 03f808b Mar 14, 2019

@andyzhangx

This comment has been minimized.

Copy link
Member Author

andyzhangx commented Mar 14, 2019

/test pull-kubernetes-cross

@andyzhangx andyzhangx force-pushed the andyzhangx:automated-cherry-pick-of-#75087-upstream-release-1.12 branch 2 times, most recently from 857f9f5 to 0319295 Mar 14, 2019

fix smb unmount issue on Windows
fix log warning

use IsCorruptedMnt in GetMountRefs on Windows

use errorno in IsCorruptedMnt check

fix comments: add more error code

add more error no checking

change year

fix comments

fix bazel error

fix bazel

fix bazel

fix bazel

revert bazel change

@andyzhangx andyzhangx force-pushed the andyzhangx:automated-cherry-pick-of-#75087-upstream-release-1.12 branch from 0319295 to cc4791a Mar 14, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 14, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andyzhangx
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jingxu97

If they are not already assigned, you can assign the PR to them by writing /assign @jingxu97 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Mar 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.