Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #74653: Distinguish volume path with mount path #75364

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@cofyc
Copy link
Contributor

cofyc commented Mar 14, 2019

Cherry pick of #74653 on release-1.13.

#74653: Distinguish volume path with mount path

Because some plugins mount volume on sub-directory of volume path, we need to distinguish between volume path and mount path to fix issue in reconstruction.
@cofyc

This comment has been minimized.

Copy link
Contributor Author

cofyc commented Mar 14, 2019

/assign @tpepper
for 1.13 patch release
/assign @msau42 @saad-ali
for approval

@cofyc

This comment has been minimized.

Copy link
Contributor Author

cofyc commented Mar 14, 2019

I've added release note in parent PR #74653 just now. Do you know how to remove do-not-merge/release-note-label-needed label on this PR?

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Mar 14, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 14, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cofyc

This comment has been minimized.

Copy link
Contributor Author

cofyc commented Mar 15, 2019

/test pull-kubernetes-verify

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 16, 2019

@aleksandra-malinowska @tpepper could you approve this cherry-pick to 1.13 please? It will help with deflaking blocking upgrade tests.

@cofyc I think this PR is also missing release notes (can be none if you think that's best).

@cofyc

This comment has been minimized.

Copy link
Contributor Author

cofyc commented Mar 16, 2019

@mariantalla I’ve added release notes. However it seems that prow cannot propagate release notes status to this pr automatically after it is created. I hope someone with admin permission can help us. @cblecker could you do me a favor?

Edit: Fixed now. I copied release notes to this cherry-pick PR from parent.

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 18, 2019

/assign @aleksandra-malinowska @tpepper

Could you approve this cherry-pick please? I think it looks good to go otherwise.

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 18, 2019

/kind bug
(same as #74653)

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels Mar 18, 2019

@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Mar 18, 2019

/retest

6 similar comments
@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Mar 18, 2019

/retest

@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Mar 18, 2019

/retest

@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Mar 18, 2019

/retest

@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Mar 19, 2019

/retest

@cofyc

This comment has been minimized.

Copy link
Contributor Author

cofyc commented Mar 19, 2019

/retest

@cofyc

This comment has been minimized.

Copy link
Contributor Author

cofyc commented Mar 19, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 19, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 19, 2019

/retest

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 19, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot merged commit 20cdc6c into kubernetes:release-1.13 Mar 19, 2019

17 checks passed

cla/linuxfoundation cofyc authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.