Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #74652: Delay CSI client initialization #75366

Conversation

cofyc
Copy link
Member

@cofyc cofyc commented Mar 14, 2019

Cherry pick of #74652 on release-1.13.

#74652: Delay CSI client initialization

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 14, 2019
@cofyc
Copy link
Member Author

cofyc commented Mar 14, 2019

/assign @tpepper
for 1.13 patch release
/assign @msau42 @saad-ali
for approval

This and #75364 are used to fix e2e test failures in downgrade test.

xref: #75196

@mariantalla
Copy link
Contributor

Also assigning @aleksandra-malinowska for cherry-pick
/assign @aleksandra-malinowska

@mariantalla
Copy link
Contributor

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 14, 2019
@msau42
Copy link
Member

msau42 commented Mar 14, 2019

#75364 should go in first
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2019
@mariantalla
Copy link
Contributor

@aleksandra-malinowska @tpepper could you approve this cherry-pick to 1.13 please? It will help with deflaking blocking upgrade tests.

@tpepper
Copy link
Member

tpepper commented Mar 18, 2019

/kind failing-test

@aleksandra-malinowska aleksandra-malinowska added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 18, 2019
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 18, 2019
@mariantalla
Copy link
Contributor

mariantalla commented Mar 18, 2019

#75364 is currently merging; will leave lgtm, approve and hold-cancel to you @msau42 @saad-ali

@saad-ali
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2019
@mariantalla
Copy link
Contributor

Heads up: #75364 is in 😓

@msau42 I think it's only missing lgtm and hold-cancel (provided you're happy with everything else of course)

@mariantalla
Copy link
Contributor

Adding it to milestone as it's relevant to the 1.14 release (helps stabilize upgrade tests):

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 19, 2019
@msau42
Copy link
Member

msau42 commented Mar 19, 2019

Thanks for shepherding all of this!
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 693b636 into kubernetes:release-1.13 Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants