Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #74652: Delay CSI client initialization #75366

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@cofyc
Copy link
Contributor

cofyc commented Mar 14, 2019

Cherry pick of #74652 on release-1.13.

#74652: Delay CSI client initialization

@cofyc

This comment has been minimized.

Copy link
Contributor Author

cofyc commented Mar 14, 2019

/assign @tpepper
for 1.13 patch release
/assign @msau42 @saad-ali
for approval

This and #75364 are used to fix e2e test failures in downgrade test.

xref: #75196

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 14, 2019

Also assigning @aleksandra-malinowska for cherry-pick
/assign @aleksandra-malinowska

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 14, 2019

/priority important-soon

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 14, 2019

#75364 should go in first
/hold

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 16, 2019

@aleksandra-malinowska @tpepper could you approve this cherry-pick to 1.13 please? It will help with deflaking blocking upgrade tests.

@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Mar 18, 2019

/kind failing-test

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 18, 2019

#75364 is currently merging; will leave lgtm, approve and hold-cancel to you @msau42 @saad-ali

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Mar 18, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cofyc, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 19, 2019

Heads up: #75364 is in 😓

@msau42 I think it's only missing lgtm and hold-cancel (provided you're happy with everything else of course)

@mariantalla

This comment has been minimized.

Copy link
Contributor

mariantalla commented Mar 19, 2019

Adding it to milestone as it's relevant to the 1.14 release (helps stabilize upgrade tests):

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 19, 2019

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 19, 2019

Thanks for shepherding all of this!
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Mar 19, 2019

@k8s-ci-robot k8s-ci-robot merged commit 693b636 into kubernetes:release-1.13 Mar 19, 2019

17 checks passed

cla/linuxfoundation cofyc authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.