Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
fix race condition issue for smb mount on windows #75371
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
hi @michmike I could easily repro this issue by "kubectl create -f https://raw.githubusercontent.com/andyzhangx/demo/master/windows/azurefile/aspnet-azurefile-multiple-replicas.yaml", the error is like following:
And I have verified this PR has fixed this issue. It's better make it into v1.14 if possible.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
I have a few questions
I introduced a fix for remount same smb path issue on windows: #73661, that fix introduces this issue, it's not a regression btw since original remount on same smb path does not work.
I used 6 replicas in my example, though those pod has different mount dirs, while they point to same smb path, that will cause race condition.
If you use same smb path with multiple pods in parallel, I think it could reproduce easily.
@jingxu97 Let me explain a little more here. On Linux, every smb mount is independent even mount with same smb path, so there won't be race condition, while on Windows, we are using