Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fsnotify vendor to 1.4.7 #75376

Merged
merged 1 commit into from Mar 20, 2019

Conversation

@cpuguy83
Copy link
Contributor

cpuguy83 commented Mar 14, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fixes a number of issues including deadlocks and leaking file
descriptors due to not using O_CLOEXEC

Which issue(s) this PR fixes:

Special notes for your reviewer:

There are other fixes in fsnotify for O_CLOEXEC on master, but there is no release yet.

Does this PR introduce a user-facing change?:

Fix some potential deadlocks and file descriptor leaking for inotify watches.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 14, 2019

Hi @cpuguy83. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpuguy83

This comment has been minimized.

Copy link
Contributor Author

cpuguy83 commented Mar 14, 2019

/assign cblecker

@cpuguy83

This comment has been minimized.

Copy link
Contributor Author

cpuguy83 commented Mar 14, 2019

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node and removed needs-sig labels Mar 14, 2019

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Mar 15, 2019

/ok-to-test

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Mar 15, 2019

@cpuguy83 Could you add a release note? I think it should be cherry picked to 1.12 and 1.13.

@feiskyer
Copy link
Member

feiskyer left a comment

/lgtm

Bump fsnotify vendor to 1.4.7
This fixes a number of issues including deadlocks and leaking file
descriptors due to not using `O_CLOEXEC`

@cpuguy83 cpuguy83 force-pushed the cpuguy83:bump_fsnotify_vendor branch from c29e9c5 to 4482e3f Mar 15, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 15, 2019

@cpuguy83

This comment has been minimized.

Copy link
Contributor Author

cpuguy83 commented Mar 15, 2019

/retest pull-kubernetes-kubemark-e2e-gce-big

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Mar 16, 2019

/retest
/lgtm
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 16, 2019

@dims

This comment has been minimized.

Copy link
Member

dims commented Mar 18, 2019

/test pull-kubernetes-cross

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Mar 20, 2019

/retest
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cpuguy83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ac6b1a1 into kubernetes:master Mar 20, 2019

17 checks passed

cla/linuxfoundation cpuguy83 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@cpuguy83 cpuguy83 deleted the cpuguy83:bump_fsnotify_vendor branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.