Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb CUSTOM_INGRESS_YAML into other setup scripts #75381

Merged
merged 1 commit into from Mar 25, 2019

Conversation

@rramkumar1
Copy link
Member

rramkumar1 commented Mar 14, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We need this so that we can set a custom YAML for Ingress-GCE inside of a prow job.

Will verify that this works by: setting the envvar, calling kubetest locally and verifying the provided value was plumbed all the way through.

None

/assign @bowei

@rramkumar1 rramkumar1 force-pushed the rramkumar1:configure-scripts-for-ingress-yaml branch from e2ec9e8 to 8ac15cd Mar 15, 2019

@rramkumar1

This comment has been minimized.

Copy link
Member Author

rramkumar1 commented Mar 21, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@rramkumar1

This comment has been minimized.

Copy link
Member Author

rramkumar1 commented Mar 21, 2019

@bowei I verified this works as expected in an e2e cluster so this is good to go for review.

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Mar 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 25, 2019

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Mar 25, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9e1cf75 into kubernetes:master Mar 25, 2019

17 checks passed

cla/linuxfoundation rramkumar1 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.