Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to USE_RELEASE_NODE_BINARIES. #75387

Merged
merged 1 commit into from Mar 18, 2019

Conversation

@pjh
Copy link
Contributor

pjh commented Mar 14, 2019

This variable was used for development purposes and was accidentally
introduced in
f0f7829.

This is its only use in the tree:
https://github.com/kubernetes/kubernetes/search?q=USE_RELEASE_NODE_BINARIES&unscoped_q=USE_RELEASE_NODE_BINARIES

/kind cleanup

NONE
Remove reference to USE_RELEASE_NODE_BINARIES.
This variable was used for development purposes and was accidentally
introduced in
f0f7829.

This is its only use in the tree:
https://github.com/kubernetes/kubernetes/search?q=USE_RELEASE_NODE_BINARIES&unscoped_q=USE_RELEASE_NODE_BINARIES
@pjh

This comment has been minimized.

Copy link
Contributor Author

pjh commented Mar 14, 2019

/cc yujuhong

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Mar 14, 2019

The PR removes a redundant/unused environment variable.

/lgtm

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Mar 14, 2019

/assign @mikedanese
/assign @spiffxp

@BenTheElder
Copy link
Member

BenTheElder left a comment

/lgtm

@soggiest

This comment has been minimized.

Copy link
Contributor

soggiest commented Mar 15, 2019

/approve
Looks like I don't have approval access. @BenTheElder do you mind apply /approve ?

@xmudrii

This comment has been minimized.

Copy link
Member

xmudrii commented Mar 18, 2019

@BenTheElder @spiffxp Is this PR still planned to be merged for 1.14? If yes it would be nice to get approved this PR before Code Thaw (tomorrow PST EOD), so it doesn't have to compete with other non-1.14 PRs.

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Mar 18, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjh, soggiest, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 28910bf into kubernetes:master Mar 18, 2019

17 checks passed

cla/linuxfoundation pjh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.