Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use golang 1.12.1 #75392

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@dims
Copy link
Member

dims commented Mar 15, 2019

Change-Id: I52665378c6bce66530d11c4b3c9ad6c2cce1da1f

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #74890

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use golang 1.12.1
update to go1.12.1
Change-Id: I52665378c6bce66530d11c4b3c9ad6c2cce1da1f

@dims dims changed the title update to go1.12.1 Update to use golang 1.12.1 Mar 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dims
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ixdy

If they are not already assigned, you can assign the PR to them by writing /assign @ixdy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Mar 15, 2019

/kind bug
/priority critical-urgent

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Mar 15, 2019

Fixes #74890

change to xref #74890 ?

Allow REGISTRY to be specified externally
Change-Id: Ibe08435baed79c8ac87beebf9a7f5dc435d49fc3
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Mar 15, 2019

/test pull-kubernetes-verify

the other 2 jobs are waiting on golang 1.12.1 to hit dockerhub, essentially we need the following to merge:
docker-library/official-images#5550

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

@dims: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 664e012 link /test pull-kubernetes-cross
pull-kubernetes-godeps 664e012 link /test pull-kubernetes-godeps
pull-kubernetes-verify 664e012 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims dims closed this Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.