Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Speculative workaround for #74890" #75393

Merged
merged 1 commit into from Mar 16, 2019

Conversation

@neolit123
Copy link
Member

neolit123 commented Mar 15, 2019

Reverts #75305

Umbrella issue: migrate kubernetes to Go 1.12.1
xref: #75372

/assign @spiffxp @dims
cc @justinsb
/priority critical-urgent
/kind failing-test

/hold
please unhold once test-infra and k/k are ready with go 1.12.1

cc @maria @alejandrox1
after this PR merges we need to watch the tests from this ticket again:
#74890

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

@neolit123: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Mar 15, 2019

/sig release
/release-note-none

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Mar 15, 2019

/retest

@liggitt liggitt added this to the v1.14 milestone Mar 15, 2019

@dims

This comment has been minimized.

Copy link
Member

dims commented Mar 15, 2019

/approve
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Mar 15, 2019

@dims

This comment has been minimized.

Copy link
Member

dims commented Mar 15, 2019

/assign @liggitt @ixdy

Jeff, Jordan, please /approve this ... we need to go back to sync.Once now that one way or another we will be using 1.12.1 golang

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Mar 15, 2019

/approve
/hold

should we wait for #75413 to merge first?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ixdy, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member

dims commented Mar 15, 2019

/hold cancel

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 15, 2019

won't this reintroduce problems with diffResources until #75413 merges?

@dims

This comment has been minimized.

Copy link
Member

dims commented Mar 15, 2019

@liggitt yep, the other one is almost ready

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Mar 15, 2019

/lgtm

(in case anyone thought I might be upset about seeing this reverted ;-) )

@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Mar 15, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit f539875 into kubernetes:master Mar 16, 2019

17 checks passed

cla/linuxfoundation neolit123 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.