Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeletePropagationBackground DeleteOptions to deployment controller #75398

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@goodluckbot
Copy link
Contributor

goodluckbot commented Mar 15, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Several resources default to orphaning dependents for backwards compatibility:
deployments in extensions/v1beta1, apps/v1beta1, apps/v1beta2
Calls made via client-go to delete these resource via these versions which do not specify a deletion propagation policy default to orphaning dependents.
This PR added propagation for deployment.

Which issue(s) this PR fixes:
Fixes #71807
cc @liggitt

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

Hi @goodluckbot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: goodluckbot
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nikhiljindal

If they are not already assigned, you can assign the PR to them by writing /assign @nikhiljindal in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 15, 2019

thanks for the PR, but this API call is using apps/v1, which does not have the problem described in the issue.

the things that still need sweeping are controller delete calls for these resources:

  • jobs in batch/v1
  • cronjobs in batch/v1beta1, batch/v2alpha1
  • replicationcontrollers in v1
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 15, 2019

/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 15, 2019

@liggitt: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@goodluckbot

This comment has been minimized.

Copy link
Contributor Author

goodluckbot commented Mar 15, 2019

Thanks @liggitt , it seems there's no delete calls wrt to these 3 controllers?

  • jobs in batch/v1
  • cronjobs in batch/v1beta1, batch/v2alpha1
  • replicationcontrollers in v1
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 15, 2019

the only one I see is

return r.KubeClient.BatchV1().Jobs(namespace).Delete(name, &metav1.DeleteOptions{PropagationPolicy: &background})
which is already using background propagation policy

a lot of controllers got switched to use apps/v1 in 1.14, so the parent issue can be closed now

@goodluckbot

This comment has been minimized.

Copy link
Contributor Author

goodluckbot commented Mar 15, 2019

ok got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.