Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go1.12.1 #75413

Merged
merged 4 commits into from Mar 16, 2019

Conversation

@BenTheElder
Copy link
Member

commented Mar 15, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

  • Updates the kube-cross image to install go 1.12.1 while we wait on docker-library/official-images#5550
  • Upgrades the bazel build to rules_go 0.17.2 and go1.12.1
  • Upgrades test/images to go1.12.1

We need this so we can get more CI signal with go 1.12.1.

When to upstream golang 1.12.1 image is out we should update kube-cross to use that, in the meantime we've borrowed the go install snippet to install 1.12.1 on top of the 1.12 base image.

Which issue(s) this PR fixes:

Related to #75372

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go1.12.1

/sig release

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

cc @dims @amwat
need to actually build this next.

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

xref: #75372

@k8s-ci-robot k8s-ci-robot requested review from ixdy and lavalamp Mar 15, 2019

BenTheElder added some commits Mar 15, 2019

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

I just built the cross image locally and then docker tag staging-k8s.gcr.io/kube-cross:v1.12.1-1 k8s.gcr.io/kube-cross:v1.12.1-1, running a `make quick-release to sanity check it.

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

make quick-release sanity checks fine, also:

$ build/run.sh go version
+++ [0315 11:08:17] Verifying Prerequisites....
+++ [0315 11:08:17] Building Docker image kube-build:build-f5f495327d-5-v1.12.1-1
+++ [0315 11:08:22] Keeping container kube-build-data-f5f495327d-5-v1.12.1-1
+++ [0315 11:08:22] Keeping container kind-control-plane
+++ [0315 11:08:22] Keeping container kube-build-data-14b730b626-5-v1.11.5-1
+++ [0315 11:08:22] Keeping container awesome_fermi
+++ [0315 11:08:22] Keeping container musing_shockley
+++ [0315 11:08:22] Keeping container laughing_hodgkin
+++ [0315 11:08:22] Keeping container kube-build-data-f5f495327d-5-v1.12.1-1
+++ [0315 11:08:22] Keeping container kind-control-plane
+++ [0315 11:08:22] Keeping container kube-build-data-14b730b626-5-v1.11.5-1
+++ [0315 11:08:22] Keeping container awesome_fermi
+++ [0315 11:08:22] Keeping container musing_shockley
+++ [0315 11:08:22] Keeping container laughing_hodgkin
+++ [0315 11:08:22] Keeping container kube-build-data-f5f495327d-5-v1.12.1-1
+++ [0315 11:08:22] Keeping container kind-control-plane
+++ [0315 11:08:22] Keeping container kube-build-data-14b730b626-5-v1.11.5-1
+++ [0315 11:08:22] Keeping container awesome_fermi
+++ [0315 11:08:22] Keeping container musing_shockley
+++ [0315 11:08:22] Keeping container laughing_hodgkin
+++ [0315 11:08:22] Keeping image kube-build:build-f5f495327d-5-v1.12.1-1
+++ [0315 11:08:22] Keeping image kube-build:build-14b730b626-5-v1.11.5-1
+++ [0315 11:08:22] Syncing sources to container
+++ [0315 11:08:22] Stopping any currently running rsyncd container
+++ [0315 11:08:22] Starting rsyncd container
+++ [0315 11:08:23] Running rsync
+++ [0315 11:08:24] Stopping any currently running rsyncd container
+++ [0315 11:08:25] Output from this container will be rsynced out upon completion. Set KUBE_RUN_COPY_OUTPUT=n to disable.
+++ [0315 11:08:25] Running build command...
go version go1.12.1 linux/amd64
+++ [0315 11:08:27] Syncing out of container
+++ [0315 11:08:27] Stopping any currently running rsyncd container
+++ [0315 11:08:27] Starting rsyncd container
+++ [0315 11:08:28] Running rsync
+++ [0315 11:08:28] Stopping any currently running rsyncd container
@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

[filed a CL to promote the image, we are waiting on that now, cross, verify, and verify-godeps will fail until the image is available]

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/priority critical-urgent
/kind cleanup
(we really need a better set of kind to cover things like this)

@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/assign @ixdy @dims

@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

NOTE: we dont' yet have 1.12.1 golang image as of today (Fri Mar 15, approx 2:30 PM East coast). To make progress over the weekend to get good CI signal, we need this PR to merge quickly.

Once we get an official image early next week, we can remove the hack in Dockerfile and use the 1.12.1 in the FROM directive.

Thanks for doing this @BenTheElder much appreciated

/approve
/lgtm

(in principle)

@tallclair

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/lgtm

@amwat

This comment has been minimized.

Copy link

commented Mar 15, 2019

/retest

1 similar comment
@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/retest

@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/test pull-kubernetes-cross
/test pull-kubernetes-godeps

@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/test pull-kubernetes-cross

1 similar comment
@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/test pull-kubernetes-cross

@@ -17,6 +17,50 @@

FROM golang:1.12.0

This comment has been minimized.

Copy link
@ixdy

ixdy Mar 15, 2019

Member

the 1.12.1 tag is now published. do we still want to merge this workaround?

This comment has been minimized.

Copy link
@dims

dims Mar 15, 2019

Member

@ixdy yes, This lets get the CI jobs get started quicker. We can revert things back on monday (and publish fresh images)

This comment has been minimized.

Copy link
@dims

This comment has been minimized.

Copy link
@ixdy

ixdy Mar 15, 2019

Member

The PR merged a few hours ago, but you can also now pull the image, meaning this workaround isn't needed:

$ docker pull golang:1.12.1
1.12.1: Pulling from library/golang
22dbe790f715: Pull complete
0250231711a0: Pull complete
6fba9447437b: Pull complete
c2b4d327b352: Pull complete
619f4932b7ea: Pull complete
16e105463ffe: Pull complete
ed842bbe1793: Pull complete
Digest: sha256:8630e0f0e9a8187f54066ea81a9fe33a21ddbfbe88c7149fe2299d8cd989ad63
Status: Downloaded newer image for golang:1.12.1

This comment has been minimized.

Copy link
@dims

dims Mar 15, 2019

Member

@ixdy i am happy for us to switch things back right now if you, @amwat and @BenTheElder are ok with it.

This comment has been minimized.

Copy link
@liggitt

liggitt Mar 15, 2019

Member

build-cross v1.12.1-1 is already pushed with this workaround, so we should commit this to record the source of v1.12.1-1. that will also let CI soak begin for the weekend while a v1.12.1-2 without this workaround gets pushed.

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Mar 15, 2019

Author Member

I'm up to switch it but it sounds like for now we want to let the CI soak then switch it for v1.12.1-2?
https://kubernetes.slack.com/archives/C2C40FMNF/p1552691032534800

@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/retest

@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 15, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/assign @liggitt

@dims

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

please see discussion at https://kubernetes.slack.com/archives/C2C40FMNF/p1552690316531000 to approve this PR

@liggitt

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/retest

1 similar comment
@tpepper

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2019

/retest

@BenTheElder

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2019

That has to be the least useful junit output ever.

/retest

@tpepper

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit f3fdac1 into kubernetes:master Mar 16, 2019

17 checks passed

cla/linuxfoundation BenTheElder authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@BenTheElder BenTheElder deleted the BenTheElder:cross-1.12.1 branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.