Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore machine readability to the print-join-command output #75487

Merged

Conversation

@displague
Copy link
Contributor

commented Mar 19, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

The output of kubeadm token create --print-join-command should be
usable by batch scripts.

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1454

kubeadm: fix the machine readability of "kubeadm token create --print-join-command"
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Hi @displague. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timothysc

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

/ok-to-test

@timothysc
Copy link
Member

left a comment

/lgtm
/approve
/hold

Please add a release note to this PR.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: displague, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabriziopandini

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@displague thanks for the quick fix
In v1.15 probably we should look for a better solution, but I'm ok with this now
/lgtm

@displague

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

I'm going to remove the tabs as well. All of the other parameters end with a space so the tabs are not needed and make for strange single line output.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 19, 2019

Restore machine readability to the print-join-command output
The output of `kubeadm token create --print-join-command` should be
usable by batch scripts. This issue was pointed out in:

kubernetes/kubeadm#1454

@displague displague force-pushed the displague:machine-readable-kubeadm-join branch from 341e204 to 10102ce Mar 19, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 19, 2019

@neolit123
Copy link
Member

left a comment

/lgtm
thanks..

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 19, 2019

@neolit123

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

i will send a cherry pick for the release-1.14 branch.
this fix should be up rc2.

@neolit123

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@spiffxp spiffxp referenced this pull request Mar 19, 2019

@k8s-ci-robot k8s-ci-robot merged commit e6272b8 into kubernetes:master Mar 19, 2019

17 checks passed

cla/linuxfoundation displague authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@displague displague deleted the displague:machine-readable-kubeadm-join branch Mar 20, 2019

k8s-ci-robot added a commit that referenced this pull request Mar 20, 2019
Merge pull request #75489 from neolit123/automated-cherry-pick-of-#75…
…487-origin-release-1.14

Automated cherry pick of #75487: Restore machine readability to the print-join-command output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.