Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubectl: support inline csi volume #75513

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@cwdsuzhou
Copy link
Member

commented Mar 20, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Kubectl can not describe inline csi volume correctly.
image

Which issue(s) this PR fixes:

Fixes #75512

Special notes for your reviewer:
cc @liggitt
Does this PR introduce a user-facing change?:

NONE

/sig cli

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Hi @cwdsuzhou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cwdsuzhou

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

/assign @soltysh
/assign @liggitt

@fejta-bot

This comment has been minimized.

Copy link

commented Mar 20, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@cwdsuzhou

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

/remove-kind api-change

@neolit123

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

/sig storage

@cwdsuzhou

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

/assign @juanvallejo

@juanvallejo

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

@cwdsuzhou Thanks! Could you add some sample output of what it looks like with this patch?

/lgtm

cc @soltysh or @seans3 for approval

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 23, 2019

@cwdsuzhou

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2019

@juanvallejo thanks for your review. I would add some sample output later. You could see #75512, I have pasted the desired output there

@cwdsuzhou

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

ping @soltysh @seans3, would you please help review this pr.

@soltysh
Copy link
Contributor

left a comment

/lgtm
/approve

func printCSIVolumeSource(csi *corev1.CSIVolumeSource, w PrefixWriter) {
var readOnly bool
var fsType string
if csi.ReadOnly != nil && *csi.ReadOnly {

This comment has been minimized.

Copy link
@soltysh

soltysh Mar 27, 2019

Contributor

Next time do:

readOnly := csi.ReadOnly != nil && *csi.ReadOnly

less typing 😉

This comment has been minimized.

Copy link
@cwdsuzhou

cwdsuzhou Mar 27, 2019

Author Member

Thanks

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwdsuzhou, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cwdsuzhou

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@cwdsuzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanvallejo

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

/ok-to-test

@fejta-bot

This comment has been minimized.

Copy link

commented Mar 27, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 194114e into kubernetes:master Mar 28, 2019

17 checks passed

cla/linuxfoundation cwdsuzhou authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@cwdsuzhou cwdsuzhou deleted the cwdsuzhou:fix-incline-csivolume branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.