Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
vSphere: add token auth support for tags client #75515
What type of PR is this?
What this PR does / why we need it:
Support vSphere SAML token auth when using Zones.
Which issue(s) this PR fixes:
Special notes for your reviewer:
SAML auth support for the vCenter rest API endpoint came to govmomi a bit after Zone support came to vSphere Cloud Provider.
Does this PR introduce a user-facing change?:
Same for the comment/feedback on https://github.com/kubernetes/kubernetes/pull/75515/files#diff-28cf498e949ce852692c39ebc3d17818R142, does the value of Username contain the cert info? or the username?
If it contains the cert info, it's fine as is otherwise just a change to from certificate->Username. Other than that, this PR is good!
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here