Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add check-conformance-test-requirements.go #75524
What type of PR is this?
What this PR does / why we need it:
We have defined requirements of conformance test as 1, and this
If a conformance test contains SkipIfProviderIs() like
this script detects like
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
So most of the other applications in k8s follow a similar pattern or style that is k8s-idiomatic-ish go. I'd recommend follow the pattern of other cli under the
Also, did you verify that this properly hooks into all the other check functionality that are run per PR?
Thanks for your review.
OK, will check that and make this follow it.
Does "all the other check functionality" mean the other requirements of https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md#conformance-test-requirements ?
If so, I'd like to make this small as possible like current one for making a consensus.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing