Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test/e2e_kubeadm/ OWNERS file #75525

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@fabriziopandini
Copy link
Contributor

commented Mar 20, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This cycle we are going to increase E2E test coverage for kubeadm
This PR adds an OWNERS to the test/e2e_kubeadm/ folder so we can have better labeling of PRs and we can manage approval without annoying top-level approvers for test/

Special notes for your reviewer:
The list of approvers is the same of cmd/kubeadm/OWNERS and k/kubeadm

Does this PR introduce a user-facing change?:

NONE

/sig cluster-lifecycle
/area kubeadm
/priority backlog

@kubernetes/sig-cluster-lifecycle
/assign @luxas @timothysc @fabriziopandini @neolit123

@neolit123
Copy link
Member

left a comment

/lgtm
thanks for the PR @fabriziopandini !

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 20, 2019

@timothysc
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7c2b93c into kubernetes:master Mar 21, 2019

17 checks passed

cla/linuxfoundation fabriziopandini authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@fabriziopandini fabriziopandini deleted the fabriziopandini:kubeadm-test-owners branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.