Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump required minimum go version to 1.12 (strings package compatibility) #75529

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@logicalhan
Copy link
Contributor

commented Mar 20, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

We require 1.12.1 for building now due to strings package compatibility (introduced in this PR - #75487).

None
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

/assign @timothysc

@liggitt

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

/lgtm
/approve

probably worth picking to 1.14

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

/priority important-soon
/sig release

@liggitt
Copy link
Member

left a comment

/hold

Can you bump to 1.12.1?

Show resolved Hide resolved hack/lib/golang.sh Outdated

@logicalhan logicalhan force-pushed the logicalhan:bump-min-version branch from 7a21a53 to a5ddc39 Mar 20, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 20, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Mar 20, 2019

@logicalhan

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

/test pull-kubernetes-e2e-gce-100-performance

@fejta-bot

This comment has been minimized.

Copy link

commented Mar 21, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

k8s-ci-robot added a commit that referenced this pull request Mar 21, 2019

Merge pull request #75530 from logicalhan/automated-cherry-pick-of-#7…
…5529-upstream-release-1.14

Automated cherry pick of #75529: bump required minimum go version to 1.12.1 (strings pkg compatibility)

@k8s-ci-robot k8s-ci-robot merged commit b000cd4 into kubernetes:master Mar 21, 2019

17 checks passed

cla/linuxfoundation logicalhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.