Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet/rkt: Add RunInContainer()/ExecInContainer()/PortForward(). #7553

Merged
merged 1 commit into from May 1, 2015

Conversation

Projects
None yet
3 participants
@yifan-gu
Copy link
Member

commented Apr 30, 2015

@googlebot googlebot added the cla: yes label Apr 30, 2015

@vmarmol vmarmol self-assigned this Apr 30, 2015

@yifan-gu yifan-gu changed the title Rkt runner kubelet/rkt: Add basic rkt runtime routines. Apr 30, 2015

@yifan-gu yifan-gu changed the title kubelet/rkt: Add basic rkt runtime routines. rkt: Add RunInContainer()/ExecInContainer()/PortForward(). Apr 30, 2015

@yifan-gu yifan-gu changed the title rkt: Add RunInContainer()/ExecInContainer()/PortForward(). kubelet/rkt: Add RunInContainer()/ExecInContainer()/PortForward(). Apr 30, 2015

@vmarmol

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2015

Looks good overall, needs a rebase.

@yifan-gu yifan-gu force-pushed the yifan-gu:rkt_runner branch from 8068242 to 5ddb58f Apr 30, 2015

@yifan-gu

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2015

Comments addressed, rebased, but I think it will not pass CI due to missing deps #7555

@yifan-gu yifan-gu force-pushed the yifan-gu:rkt_runner branch from 5ddb58f to 2e4be0b May 1, 2015

@yifan-gu

This comment has been minimized.

Copy link
Member Author

commented May 1, 2015

Just rebased @vmarmol

@vmarmol

This comment has been minimized.

Copy link
Contributor

commented May 1, 2015

LGTM

vmarmol added a commit that referenced this pull request May 1, 2015

Merge pull request #7553 from yifan-gu/rkt_runner
kubelet/rkt: Add RunInContainer()/ExecInContainer()/PortForward().

@vmarmol vmarmol merged commit 03b5c32 into kubernetes:master May 1, 2015

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Shippable Shippable builds completed
Details
cla/google All necessary CLAs are signed

@yifan-gu yifan-gu deleted the yifan-gu:rkt_runner branch May 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.