Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New staging repository for cri-api #75531

Merged

Conversation

@dims
Copy link
Member

commented Mar 21, 2019

Change-Id: I2160b0b0ec4b9870a2d4452b428e395bbe12afbb

What type of PR is this?
/kind feature

What this PR does / why we need it:

It's hard for folks who are writing CRI implementations to vendor in code from the main kubernetes repository. Let's make it easier by adding this to staging/ and publish the API in the new repository

Which issue(s) this PR fixes:

Fixes #75293

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CRI API will now be available in the kubernetes/cri-api repository
@dims

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

/test pull-kubernetes-cross

@dims dims force-pushed the dims:add-new-staging-repository-for-cri-api branch 2 times, most recently from 910d00e to 1d5be06 Mar 21, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

/test pull-kubernetes-cross
/test pull-kubernetes-local-e2e

@zhangxiaoyu-zidif

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

is there some docs to describe those changes? or what's the ongoing plan?

@dims dims changed the title [WIP] New staging repository for cri-api New staging repository for cri-api Mar 26, 2019

@dims dims force-pushed the dims:add-new-staging-repository-for-cri-api branch from 1d5be06 to fb262ea Mar 26, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

@zhangxiaoyu-zidif interested in this work? please review/comment on the KEP kubernetes/enhancements#866

@feiskyer

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

@feiskyer is that being vendored in by other CRI implementations? pointers please (also we can do that in a follow up as we need to do a bunch of infra work with the bot etc, so we should keep this PR simple)

Yep, the package is used by all container runtimes. But it's also part of kubelet server. So maybe a separate staging is better.

@dims

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

Ack. let's do that separately

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Going to approve so I don't block this if I get distracted later today (the name looks fine, looks like process has been followed, etc)

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

/test pull-kubernetes-e2e-gce

@dims dims force-pushed the dims:add-new-staging-repository-for-cri-api branch 3 times, most recently from 3accbb5 to cb79374 Mar 26, 2019

@dims dims force-pushed the dims:add-new-staging-repository-for-cri-api branch from cb79374 to 9305180 Mar 26, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

/test pull-kubernetes-e2e-gce-100-performance

@dims dims force-pushed the dims:add-new-staging-repository-for-cri-api branch from 9305180 to de9a696 Mar 26, 2019

New staging repository for cri-api
Change-Id: I2160b0b0ec4b9870a2d4452b428e395bbe12afbb

@dims dims force-pushed the dims:add-new-staging-repository-for-cri-api branch from de9a696 to 33081c1 Mar 26, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

I think we crossed all the t's and dotted all the i's :) thanks everyone

@yujuhong

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

I think we crossed all the t's and dotted all the i's :) thanks everyone

Thanks for the PR!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 26, 2019

@feiskyer

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 4b3eb60 into kubernetes:master Mar 27, 2019

16 of 17 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Job succeeded.
Details
tide In merge pool.
Details
@BenTheElder

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

thanks @dims!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.