Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure_route support routeTableResourceGroup #75580

Merged
merged 1 commit into from Apr 2, 2019

Conversation

@suker200
Copy link
Contributor

commented Mar 22, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR adds a new parameter in the Azure Cloud Provider config file.
The new parameter is RouteTableResourceGroup. It has the same behavior as the VNetResourceGroup has for Vnet. Because sometimes, you want to use an Azure RouteTable which is not is in the same Resource Group as your main Resource Group

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
Azure Cloud Provider: Add new parameter RouteTableResourceGroup

Support specify the Resource Group of Route Table when update Pod network route (Azure)

This pr just origin from #71321 . Thanks titilambert

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

Hi @suker200. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yastij

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

/ok-to-test

@suker200

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

/test pull-kubernetes-verify

@suker200

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

I signed it

@suker200

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

@justaugustus would you please help me review on this

@yastij
yastij approved these changes Mar 25, 2019
Copy link
Member

left a comment

/lgtm
/priority backlog

@@ -941,6 +943,7 @@ func getTestCloud() (az *Cloud) {
},
ResourceGroup: "rg",
VnetResourceGroup: "rg",
RouteTableResourceGroup: "rg",

This comment has been minimized.

Copy link
@justaugustus

justaugustus Mar 28, 2019

Member

Should these have different names, e.g., rtb-rg and vnet-rg?

@justaugustus

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

LGTM, but I'd like Pengfei or Andy to review as well.
/assign @feiskyer @andyzhangx

@@ -1558,6 +1562,8 @@ aadClientSecret: --aad-client-secret--
}

// Test Configuration deserialization (yaml)
// Test Configuration deserialization (yaml) without

This comment has been minimized.

Copy link
@feiskyer

feiskyer Mar 29, 2019

Member

nit: Test Configuration deserialization (yaml) dup with above line

This comment has been minimized.

Copy link
@suker200

suker200 Apr 1, 2019

Author Contributor

done

@feiskyer

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@suker200 Could you address the comments and add a release note?

@suker200

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

@feiskyer Done. Thank you

@yastij

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 1, 2019

@feiskyer
Copy link
Member

left a comment

Looks good. Could you squash the commits?

Add azure_route support routeTableResourceGroup
fix error from pull-kubernetes-verify

fix error from pull-kubernetes-verify azure_routes_test.go file

fix error from pull-kubernetes-verify azure_routes_test.go file with gofmt

remove duplicate comment

@suker200 suker200 force-pushed the suker200:azure_routetable_rg branch from 93592ba to a343be2 Apr 2, 2019

@k8s-ci-robot k8s-ci-robot added lgtm and removed lgtm labels Apr 2, 2019

@feiskyer
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, suker200

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2fa5be1 into kubernetes:master Apr 2, 2019

17 checks passed

cla/linuxfoundation suker200 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@feiskyer feiskyer added this to In progress in Provider Azure via automation Apr 2, 2019

@feiskyer feiskyer moved this from In progress to Done in Provider Azure Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.