Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
e2e: avoid mandatory command line flags #75593
What type of PR is this?
What this PR does / why we need it:
Tests should never directly add to the global command line, because
To achieve that, e2e/framework/config, e2e/framework/viperconfig, and
The exception is framework.HandleFlags, which as before directly
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
I don't know what the status is regarding the generic config handling in Kubernetes. If this isn't usable for E2E testing or there is no-one available to make the necessary changes (I myself don't have the time, sorry), then I would prefer to merge this PR because it addresses the valid issue that @deads2k pointed out. I just haven't rebased because the PR was put on hold and wouldn't get merged.
@timothysc: I finished the rebasing.
The new viper config test revealed that the corresponding feature (loading a viper config file with explicit file suffix) had broken since introducing it in 1.13. I added the necessary fix in a separate commit, just in case that this is something we want to backport (probably not, as usage of the broken feature should be extremely small, if anyone does it at all).
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing