Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resync period for sset controller #75622

Merged
merged 1 commit into from Apr 4, 2019

Conversation

@jonsabo
Copy link
Contributor

commented Mar 23, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The stateful set controller is resyncing all ssets every 30 seconds, As discussed in the linked issue, this is not necessary, and can cause delays processing actual updates when large amounts of ssets exist.

Which issue(s) this PR fixes:
Fixes #75495

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

StatefulSet controllers no longer force a resync every 30 seconds when nothing has changed.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

Hi @jonsabo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jonsabo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps and removed needs-sig labels Mar 23, 2019

@k8s-ci-robot k8s-ci-robot requested review from foxish and smarterclayton Mar 23, 2019

@likakuli

This comment has been minimized.

Copy link

commented Mar 23, 2019

@jonsabo The default SharedInformerFactory has a default resync period, if not set in the config file, it will be 12 * Hous ~ 2 * 12 * Hours, so the statefulset still will have the probelem when use the default resync period

@jonsabo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

That seems like that might be acceptable, a quick scan looks like deployments, daemonsets, and replicasets do not explicitly set a resync

@jonsabo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

@enisoc

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

/ok-to-test
/approve

I suggest adding a bit more detail in the release note:

StatefulSet controllers no longer force a resync every 30 seconds when nothing has changed.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enisoc, jonsabo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jonsabo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

Thanks for the wording suggestion @enisoc, that seems reasonable.
/retest

@enisoc

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 4, 2019

@k8s-ci-robot k8s-ci-robot merged commit eee8af9 into kubernetes:master Apr 4, 2019

17 checks passed

cla/linuxfoundation jonsabo authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@jonsabo jonsabo deleted the jonsabo:ssetresync branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.