Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cri-tools to v1.14.0 #75658

Merged
merged 1 commit into from Apr 10, 2019

Conversation

@feiskyer
Copy link
Member

commented Mar 25, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Refer https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.14.0.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update cri-tools to v1.14.0

/assign @yujuhong @Random-Liu

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2019

/retest

1 similar comment
@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

/retest

@Random-Liu

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 26, 2019

@Random-Liu Random-Liu added this to the v1.14 milestone Mar 26, 2019

@Random-Liu

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

@feiskyer Should we cherry-pick this into 1.14?

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

/retest

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

@Random-Liu @BenTheElder Could you help to upload the binaries?

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

@feiskyer Should we cherry-pick this into 1.14?

Yep, I think so. crictl 1.12 shouldn't be used together with k8s 1.14.

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

not sure how these are uploaded, @Random-Liu or @yujuhong should know though I think.

@yujuhong

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

Spoke to @Random-Liu offline, he'll build and upload the tarball.

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

if y'all documented that process somewhere, I'd be happy to do this occasionally as well, doing that may also be helpful when we get all the release artifacts under the CNCF eventually.

@Random-Liu

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

Done.

I'll add this into the cri-tools release script.

@Random-Liu

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@feiskyer feiskyer force-pushed the feiskyer:cri-tools-1.14 branch from 768171f to 206a07b Apr 4, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 4, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

@feiskyer feiskyer force-pushed the feiskyer:cri-tools-1.14 branch from 206a07b to 1406e2b Apr 8, 2019

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

/retest

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 9, 2019

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

/assign @BenTheElder

@BenTheElder
Copy link
Member

left a comment

/lgtm
/approve
for approval:
/assign @cblecker

@cblecker

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, feiskyer, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e3c3f75 into kubernetes:master Apr 10, 2019

17 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@feiskyer feiskyer deleted the feiskyer:cri-tools-1.14 branch Apr 11, 2019

@feiskyer feiskyer restored the feiskyer:cri-tools-1.14 branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.