Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completed job status in cronjob event #75712

Merged
merged 1 commit into from Mar 29, 2019

Conversation

@danielqsj
Copy link
Member

commented Mar 26, 2019

What type of PR is this?

/kind feature
/sig apps

What this PR does / why we need it:

Now, cronjob report event about completed job but missing the job's status. It's not friendly to track cronjob status.

So add job status in cronjob event.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add completed job status in Cronjob event.
@danielqsj

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

@danielqsj danielqsj force-pushed the danielqsj:cj branch from 4145c18 to 6b2e9e8 Mar 27, 2019

@danielqsj

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

/retest

@soltysh
Copy link
Contributor

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 29, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielqsj, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16a0351 into kubernetes:master Mar 29, 2019

17 checks passed

cla/linuxfoundation danielqsj authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.