Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alpha csi CRD #75747

Merged
merged 1 commit into from Apr 3, 2019

Conversation

@msau42
Copy link
Member

commented Mar 26, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Alpha storage CRDs are no longer supported.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CSI alpha CRDs have been removed
@msau42

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

/sig storage
/priority important-soon

@k8s-ci-robot k8s-ci-robot requested review from jingax10 and mwielgus Mar 26, 2019

@msau42 msau42 changed the title Remove alpha CRD install Remove alpha csi CRD install Mar 26, 2019

@msau42

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2019

/test pull-kubernetes-node-e2e

@@ -2638,9 +2638,6 @@ EOF
if [[ "${ENABLE_DEFAULT_STORAGE_CLASS:-}" == "true" ]]; then
setup-addon-manifests "addons" "storage-class/gce"
fi
if [[ "${FEATURE_GATES:-}" =~ "AllAlpha=true" || "${FEATURE_GATES:-}" =~ "CSIDriverRegistry=true" || "${FEATURE_GATES:-}" =~ "CSINodeInfo=true" ]]; then
setup-addon-manifests "addons" "storage-crds"
fi

This comment has been minimized.

Copy link
@bertinatto

bertinatto Mar 27, 2019

Member

You might want to remove the install commands from hack/local-up-cluster.sh as well

This comment has been minimized.

Copy link
@msau42

msau42 Mar 27, 2019

Author Member

good catch, removed

@msau42 msau42 force-pushed the msau42:remove-alpha-crd branch from 114b47a to 2a66c90 Mar 27, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Mar 27, 2019

@bertinatto

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 28, 2019

@msau42 msau42 force-pushed the msau42:remove-alpha-crd branch from 2a66c90 to 51d55e1 Mar 29, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed lgtm size/S labels Mar 29, 2019

@msau42

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

Updated to also remove the files in the addons directory

@msau42 msau42 force-pushed the msau42:remove-alpha-crd branch from 51d55e1 to a5e1539 Mar 29, 2019

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 29, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Mar 29, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@msau42 msau42 force-pushed the msau42:remove-alpha-crd branch from b274f90 to 045f953 Mar 29, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 29, 2019

@msau42 msau42 force-pushed the msau42:remove-alpha-crd branch from 045f953 to 6140ff7 Mar 29, 2019

@msau42 msau42 force-pushed the msau42:remove-alpha-crd branch 2 times, most recently from 15dc778 to 4547011 Mar 29, 2019

@msau42 msau42 force-pushed the msau42:remove-alpha-crd branch from 4547011 to f804fb1 Mar 29, 2019

@msau42 msau42 changed the title Remove alpha csi CRD WIP: Remove alpha csi CRD Mar 29, 2019

@msau42 msau42 changed the title WIP: Remove alpha csi CRD Remove alpha csi CRD Mar 30, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

lgtm, needs rebase

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt added this to the v1.15 milestone Apr 2, 2019

@msau42 msau42 force-pushed the msau42:remove-alpha-crd branch from f804fb1 to d2aa817 Apr 2, 2019

@msau42

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

Rebased

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

/lgtm

@sttts, fyi

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 2, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 2, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented Apr 3, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 4287748 into kubernetes:master Apr 3, 2019

9 of 17 checks passed

pull-kubernetes-cross Job triggered.
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-godeps Job triggered.
Details
pull-kubernetes-integration Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-node-e2e Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation msau42 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-publishing-bot-validate Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.