Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up func podTimestamp in queue #75754

Merged
merged 1 commit into from Mar 30, 2019

Conversation

@denkensk
Copy link
Member

commented Mar 27, 2019

What type of PR is this?
/kind cleanup
/sig scheduling

What this PR does / why we need it:
After PR #73700 is merged, we use the podInfo.timestamp as the time pod added to the scheduling queue. And The func podTimestamp isn't used anymore, so remove it to make code clean.

NONE
@denkensk

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

/test pull-kubernetes-integration

@wgliang
Copy link
Member

left a comment

/lgtm

@denkensk

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

/assign @bsalamat

@bsalamat
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, denkensk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a9584a2 into kubernetes:master Mar 30, 2019

17 checks passed

cla/linuxfoundation denkensk authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.