Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete prority for rs #75763

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@lovejoy
Copy link
Contributor

commented Mar 27, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

user want to control which pod will be deleted
Which issue(s) this PR fixes:

Fixes #45509

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Pod has the controller.alpha.kubernetes.io/delete-priority annotation with a high value will be delete first by rs controller
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Hi @lovejoy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lovejoy
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: derekwaynecarr

If they are not already assigned, you can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

/ok-to-test

@lovejoy

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

/kind feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.