Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude custom transports when constructing AnonymousClientConfig() #75771

Merged
merged 1 commit into from Apr 4, 2019

Conversation

@liggitt
Copy link
Member

commented Mar 27, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
The AnonymousClientConfig() method returns a copy of a rest.Config struct, copying only fields that are known to not contain credentials.

The custom Transport and WrapTransport config fields can be used to inject credentials,
so those should not be included.

Does this PR introduce a user-facing change?:

client-go: The `rest.AnonymousClientConfig(*rest.Config) *rest.Config` helper method no longer copies custom `Transport` and `WrapTransport` fields, because those can be used to inject user credentials.

xref #76797

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

@k8s-ci-robot k8s-ci-robot requested a review from tallclair Mar 27, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tallclair

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

lgtm

@enj

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 1, 2019

@k8s-ci-robot k8s-ci-robot merged commit fc556f0 into kubernetes:master Apr 4, 2019

17 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:AnonymousClientConfig branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.