Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-aggregator: bump openapi aggregation log level for delegation targets #75781

Merged

Conversation

@roycaihw
Copy link
Member

commented Mar 27, 2019

fixes #75777

in 1.14 we increased the frequency of resyncing local openapi specs to once per second. However the controller logs every item unbiasedly without verbose level set. As a result many local openapi aggregation logs are generated during normal operation.

This PR bumps the verbose level if the item is a local spec.

Does this PR introduce a user-facing change?:

Increased verbose level for local openapi aggregation logs to avoid flooding the log during normal operation

we'll need to cherry-pick the fix for 1.14.1

if aggregator.IsLocalAPIService(key.(string)) {
// for local delegation targets that are aggregated once per second, log at
// higher level to avoid flooding the log
klog.V(4).Infof("OpenAPI AggregationController: Processing item %s", key)

This comment has been minimized.

Copy link
@roycaihw

roycaihw Mar 27, 2019

Author Member

I'm not sure if V(4) is appropriate. maybe we can go with higher level? do we have verbose level convention documented somewhere?

This comment has been minimized.

This comment has been minimized.

Copy link
@roycaihw

roycaihw Mar 29, 2019

Author Member

@liggitt thanks! I updated the number

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

/assign @mbohlool

@roycaihw roycaihw force-pushed the roycaihw:fix/openapi-aggregator-log branch from b7f0252 to 597929a Mar 29, 2019

// higher level to avoid flooding the log
klog.V(5).Infof("OpenAPI AggregationController: Processing item %s", key)
} else {
klog.Infof("OpenAPI AggregationController: Processing item %s", key)

This comment has been minimized.

Copy link
@liggitt

liggitt Mar 29, 2019

Member

in failure cases, how often is this logged?

This comment has been minimized.

Copy link
@roycaihw

roycaihw Apr 2, 2019

Author Member

the key is re-queued by a rate limiter with 1 min base delay and 1 hr max delay (backoff exponentially)

@sttts

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

/lgtm
/approve

@sttts

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

I agree about picking it to 1.14.x.

@sttts sttts removed the needs-priority label Apr 1, 2019

@sttts

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

/assign @deads2k

for approval.

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, roycaihw, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a0e71b4 into kubernetes:master Apr 1, 2019

17 checks passed

cla/linuxfoundation roycaihw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request Apr 4, 2019

Merge pull request #75996 from roycaihw/automated-cherry-pick-of-#757…
…81-upstream-release-1.14

Automated cherry pick of #75781: kube-aggregator: bump openapi aggregation log level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.