Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return empty devicepath for csi attach #75799

Merged
merged 1 commit into from Mar 29, 2019

Conversation

@msau42
Copy link
Member

commented Mar 28, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
In 1.13, csi node plugin stopped using the devicePath passed between AD controller and kubelet. Now it is safe to remove returning the devicePath from AD controller.

Which issue(s) this PR fixes:

Fixes #71164

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

ACTION REQUIRED: The Node.Status.Volumes.Attached.DevicePath field is now unset for CSI volumes. Update any external controllers that depend on this field.
@msau42

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

@msau42

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

/priority important-longterm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

/test pull-kubernetes-e2e-gce-csi-serial

@k8s-ci-robot k8s-ci-robot requested review from saad-ali and verult Mar 28, 2019

@neolit123

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

/retest

1 similar comment
@msau42

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

/retest

@jsafrane

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 29, 2019

@k8s-ci-robot k8s-ci-robot merged commit 861f1fc into kubernetes:master Mar 29, 2019

18 checks passed

cla/linuxfoundation msau42 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.