Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: fix join control-plane with external-etcd #75847

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@fabriziopandini
Copy link
Member

commented Mar 28, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR fixes preflight checks for kubeadm join control-plane in case of external-etcd/secured

Which issue(s) this PR fixes:
Fixes # kubernetes/kubeadm#1472

Special notes for your reviewer:
This Fix is a candidate for cherry picking in v1.14

Does this PR introduce a user-facing change?:

kubeadm: preflight checks on external etcd certificates are now skipped when joining a control-plane node with automatic copy of cluster certificates (--certificate-key)

/sig cluster-lifecycle
/priority critical-urgent
/assign @neolit123 @rosti
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member

left a comment

/lgtm
thanks for the quick PR @fabriziopandini
i can send the cherry pick.

@k8s-ci-robot k8s-ci-robot merged commit 91f40ae into kubernetes:master Mar 28, 2019

17 checks passed

cla/linuxfoundation fabriziopandini authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@neolit123

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

cherry pick: #75851

@fabriziopandini fabriziopandini deleted the fabriziopandini:fix-external-etcd branch Apr 1, 2019

k8s-ci-robot added a commit that referenced this pull request Apr 4, 2019
Merge pull request #75851 from neolit123/automated-cherry-pick-of-#75…
…847-origin-release-1.14

Automated cherry pick of #75847: fix-external-etcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.