Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide imageRepository override for 'kubeadm config images' commands. #75866

Merged

Conversation

@jmkeyes
Copy link
Contributor

commented Mar 29, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR is a trivial patch to add --image-repository to all kubeadm config images commands.
This allows me to preemptively pull any required container images from a private image repository.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Does this PR introduce a user-facing change?:

Add --image-repository flag to "kubeadm config images".
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Hi @jmkeyes. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yagonobre
Copy link
Member

left a comment

Hi @jmkeyes, thanks for your pr and welcome to kubernetes :)
Can you sign the cla? and update the release note to something like this:

Add --image-repository flag to "kubeadm config images".

/ok-to-test
/priority backlog
/lgtm

@jmkeyes

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

CLA signed and PR description updated. :)

@neolit123
Copy link
Member

left a comment

thanks for the PR @jmkeyes
seems good to me as a little extension, but let see what the others think too.

/assign @rosti @fabriziopandini
@kubernetes/sig-cluster-lifecycle-pr-reviews

@rosti

rosti approved these changes Apr 3, 2019

Copy link
Member

left a comment

Thanks for your contribution @jmkeyes !
I like the idea of this. It would be beneficial to users in air-gaped environments (and China).

I'll delegate the final approval to @fabriziopandini

@fabriziopandini

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Thanks @jmkeyes for your first contribution on kubeadm !
Well done
/approve
/lgmt

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, jmkeyes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2c67581 into kubernetes:master Apr 3, 2019

17 checks passed

cla/linuxfoundation jmkeyes authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@jmkeyes jmkeyes deleted the jmkeyes:kubeadm-config-image-repository-flag branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.