Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose etcd client latency metrics #75953

Merged
merged 1 commit into from Apr 2, 2019

Conversation

@wojtek-t
Copy link
Member

commented Apr 1, 2019

Ref #75833

We used to have these metrics in etcd v2 client, but we no longer have them.
Those are also really useful for debugging purposes.

@mborsz - FYI

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

@wojtek-t: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wojtek-t

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

/retest

@wojtek-t wojtek-t force-pushed the wojtek-t:add_etcd_metrics branch from 3037e4b to 9f29de3 Apr 1, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiang90

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

@xiang90: GitHub didn't allow me to request PR reviews from the following users: WIZARD-CXY.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @WIZARD-CXY

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wojtek-t wojtek-t force-pushed the wojtek-t:add_etcd_metrics branch from 9f29de3 to d5c9ad8 Apr 1, 2019

@k8s-ci-robot k8s-ci-robot removed the size/S label Apr 1, 2019

@k8s-ci-robot k8s-ci-robot added the size/M label Apr 1, 2019

@jpbetz

jpbetz approved these changes Apr 1, 2019

Copy link
Contributor

left a comment

This looks right to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 1, 2019

@wojtek-t

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

/retest

@WIZARD-CXY

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@wojtek-t there is an ongoing pr which submited by me months ago #73070. Look at the both code, they are almost the same. Mine is blocked by the sttts while xiang90 and the other lgtm....

@WIZARD-CXY

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

But I'm happy to see this pr merged. After all , monitoring etcd client latency is very important and be missing so long.

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 2, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit fd23c84 into kubernetes:master Apr 2, 2019

17 checks passed

cla/linuxfoundation wojtek-t authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@wojtek-t wojtek-t deleted the wojtek-t:add_etcd_metrics branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.