Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic copyright holder name in license boilerplate #7597

Merged
merged 1 commit into from May 2, 2015

Conversation

Projects
None yet
5 participants
@eparis
Copy link
Member

commented Apr 30, 2015

The Google Contributor License Agreement (https://cla.developers.google.com/)
is not a copyright assignment. It is a license agreement. Thus it may be
incorrect for the author of a new file to claim that Google owned the
copyright in the header. Instead use a generic phrase "The Kubernetes Authors"
as the copyright holder.

@googlebot googlebot added the cla: yes label Apr 30, 2015

@eparis

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2015

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2015

LGTM, would have @thockin or @brendandburns chime in for the Google side. Discussed with the lawyers I assume?

@eparis

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2015

No. if someone on the google side wants a google lawyer to take a look, that sounds good to me.

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 1, 2015

I don't think this is an accidental oversight. @sillsm for verification.

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 1, 2015

@eparis @smarterclayton What do you think about just globally switching to "the Kubernetes Authors" instead of "Google, Inc"?

@eparis

This comment has been minimized.

Copy link
Member Author

commented May 1, 2015

Big fan. I know our legal is happy with that as well. Assuming your side is good, I'll make the change.

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 1, 2015

Yeah, SGTM (and our legal).

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented May 1, 2015

+1 - we sound all special and stuff

On May 1, 2015, at 11:57 AM, Daniel Smith notifications@github.com wrote:

Yeah, SGTM (and our legal).


Reply to this email directly or view it on GitHub.

@thockin

This comment has been minimized.

Copy link
Member

commented May 1, 2015

According to our legal folks, putting "Copyright Google" is not assigning
copyright, as much as it looks like that. We can move to the other mode
"The Kubernetes Authors" but I think we thne have to keep an AUTHORS file
and make sure contributors are listed there. Not sure if we should list
corp contribs (Red Hat Inc) or individuals.

On Fri, May 1, 2015 at 9:04 AM, Clayton Coleman notifications@github.com
wrote:

+1 - we sound all special and stuff

On May 1, 2015, at 11:57 AM, Daniel Smith notifications@github.com
wrote:

Yeah, SGTM (and our legal).


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#7597 (comment)
.

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 1, 2015

The AUTHORS file was optional ("for vanity") if I understood the lawyers correctly.

@eparis eparis force-pushed the eparis:copyright branch 2 times, most recently from 029218b to ff48375 May 1, 2015

@eparis

This comment has been minimized.

Copy link
Member Author

commented May 1, 2015

updated. Although how long any given rebase stays valid is an open question....

@eparis eparis changed the title Stop "verifying" incorrect copyright holder information in boilerplate checks Use generic copyright holder name in license boilerplate May 1, 2015

@eparis eparis referenced this pull request May 1, 2015

Merged

Boilerplate speedup #7654

Make copyright ownership statement generic
Instead of saying "Google Inc." (which is not always correct) say "The
Kubernetes Authors", which is generic.

@eparis eparis force-pushed the eparis:copyright branch from ff48375 to 6b3a6e6 May 1, 2015

@eparis

This comment has been minimized.

Copy link
Member Author

commented May 1, 2015

rebased again, as people keep changing things :)

@lavalamp lavalamp added the lgtm label May 1, 2015

@lavalamp

This comment has been minimized.

Copy link
Member

commented May 2, 2015

@jlowdermilk merging this to keep @eparis from spending the rest of his life rebasing-- hopefully it doesn't combine poorly with anything in flight.

lavalamp added a commit that referenced this pull request May 2, 2015

Merge pull request #7597 from eparis/copyright
Use generic copyright holder name in license boilerplate

@lavalamp lavalamp merged commit 4a6ab7f into kubernetes:master May 2, 2015

1 of 3 checks passed

Shippable Builds in progress on Shippable
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
cla/google All necessary CLAs are signed

@eparis eparis deleted the eparis:copyright branch Aug 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.