Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly send list metadata with v1beta1 PartialObjectMetadataList #75971

Merged

Conversation

@smarterclayton
Copy link
Contributor

commented Apr 1, 2019

The ListMeta field was accidentally omitted. The v1 api version will change the
protobuf ID ordering to match other lists, but v1beta1 can't do that without being
backwards incompatible.

/kind bug

Resource list requests for PartialObjectMetadata now correctly return list metadata like the resourceVersion and the continue token.
Add ListMeta to PartialObjectMetadataList
Unfortunately the proto id is now inconsistent with other "correct" objects,
but to change it will require a breaking serialization change. Worth considering.
@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 1, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@smarterclayton smarterclayton force-pushed the smarterclayton:fix_partialobjectmeta_list branch from 3d62474 to 6801ce9 Apr 1, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

The v1 api version will change the protobuf ID ordering to match other lists

can you open a tracking issue for fixing the tag ID in v1, and make sure that is included in our list so we don't forget?

nothing in our proto serialization/deserialization path pins tag id 1 to the list meta, right?

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

/lgtm
/approve

/hold
for question, unhold once answered

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

can you open a tracking issue for fixing the tag ID in v1, and make sure that is included in our list so we don't forget?

It's in the KEP

nothing in our proto serialization/deserialization path pins tag id 1 to the list meta, right?

correct, I had entertained the idea of a fast proto deserializer for object meta but partial mostly solves it

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

/hold cancel

@liggitt liggitt added this to the v1.15 milestone Apr 2, 2019

@k8s-ci-robot k8s-ci-robot merged commit a3ae6c4 into kubernetes:master Apr 2, 2019

17 checks passed

cla/linuxfoundation smarterclayton authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.