Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate state field of eventSeries on Event API #75987

Merged
merged 1 commit into from May 3, 2019

Conversation

@yastij
Copy link
Member

commented Apr 1, 2019

What type of PR is this?

/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The `series.state` field in the events.k8s.io/v1beta1 Event API is deprecated and will be removed in v1.18
@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 1, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

/label api-review
/priority important-soon

@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Thanks for requesting an API review. Before proceeding, please ensure the prereq checklist has been completed, especially the items related to getting agreement on the change from the area owners, and having an associated KEP.

This appears to be removing the field outright, rather than marking it as deprecated. Was this discussed and agreed to?

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

This appears to be removing the field outright, rather than marking it as deprecated. Was this discussed and agreed to?

We were discussing with @bgrant0607 and I think the decision was to deprecate.

@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

@wojtek-t @liggitt - I’m fine with this being subject to the depreciation policy, even though this was never really used somewhere. cc @bgrant0607

@yastij yastij force-pushed the yastij:event-state-deprecation branch from 1f939af to 0dde81e Apr 2, 2019

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Apr 2, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

@liggitt - Planned for removal in 1.19 as per our deprecation policy and #65782 (comment)

@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

@k8s-ci-robot k8s-ci-robot requested a review from bgrant0607 Apr 2, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

/retest

@yastij yastij force-pushed the yastij:event-state-deprecation branch from b63328e to 87a0af9 Apr 16, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Apr 16, 2019

@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

@bgrant0607 @wojtek-t - our serialization test is failing as round tripping of v1 to our internal version, this due to the fact that the storage version is v1 (so we cannot drop it from storage version as we need it to round trip v1beta1).

@yastij yastij force-pushed the yastij:event-state-deprecation branch from 87a0af9 to 8221fff Apr 16, 2019

@bgrant0607

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@yastij Yes, sorry, I didn't read the text I copied too carefully. I'm fine with deprecate now and remove in a couple releases.

@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

@bgrant0607 - less than year would make us deprecate this in 1.18. would you prefer to deprecate this in 1.19 to respect the deprecation policy ?

@liggitt liggitt moved this from In progress to Changes requested in API Reviews Apr 16, 2019

@liggitt liggitt moved this from Changes requested to In progress in API Reviews Apr 16, 2019

@liggitt liggitt moved this from In progress to Changes requested in API Reviews Apr 18, 2019

@bgrant0607

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@yastij I'm fine with 1.18.

@yastij

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2019

/retest
/uncc @dchen1107 @nikhiljindal

@yastij yastij force-pushed the yastij:event-state-deprecation branch from 8221fff to 0f3e9ca Apr 28, 2019

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Apr 28, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented May 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label May 2, 2019

@liggitt liggitt moved this from Changes requested to Completed, 1.15 in API Reviews May 2, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented May 2, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented May 2, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot

This comment has been minimized.

Copy link

commented May 2, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented May 3, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 8136cfc into kubernetes:master May 3, 2019

20 checks passed

cla/linuxfoundation yastij authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.