deprecate state field of eventSeries on Event API

[yastij]

What type of PR is this?

/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The `series.state` field in the events.k8s.io/v1beta1 Event API is deprecated and will be removed in v1.18

[yastij]

/assign @bgrant0607 @wojtek-t

[fejta-bot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[yastij]

/label api-review
/priority important-soon

[yastij]

/retest

[liggitt]

Thanks for requesting an API review. Before proceeding, please ensure the prereq checklist has been completed, especially the items related to getting agreement on the change from the area owners, and having an associated KEP.

This appears to be removing the field outright, rather than marking it as deprecated. Was this discussed and agreed to?

[wojtek-t]

This appears to be removing the field outright, rather than marking it as deprecated. Was this discussed and agreed to?

We were discussing with @bgrant0607 and I think the decision was to deprecate.

[yastij]

@wojtek-t @liggitt - I’m fine with this being subject to the depreciation policy, even though this was never really used somewhere. cc @bgrant0607

[yastij]

@liggitt - Planned for removal in 1.19 as per our deprecation policy and #65782 (comment)

[yastij]

/cc @bgrant0607 @liggitt

[yastij]

/retest

[yastij]

@bgrant0607 @wojtek-t - our serialization test is failing as round tripping of v1 to our internal version, this due to the fact that the storage version is v1 (so we cannot drop it from storage version as we need it to round trip v1beta1).

[bgrant0607]

@yastij Yes, sorry, I didn't read the text I copied too carefully. I'm fine with deprecate now and remove in a couple releases.

[yastij]

@bgrant0607 - less than year would make us deprecate this in 1.18. would you prefer to deprecate this in 1.19 to respect the deprecation policy ?

[bgrant0607]

@yastij I'm fine with 1.18.

[yastij]

/retest
/uncc @dchen1107 @nikhiljindal

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• api/OWNERS [liggitt]
• pkg/apis/core/OWNERS [liggitt]
• staging/src/k8s.io/api/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liggitt]

/retest

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.