Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give users option to suppress detailed output in integration test #76063

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@Huang-Wei
Copy link
Member

commented Apr 3, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

In integration test script, alsologtostderr is hardcoded to true (in #32532) to expose detailed output. And the parameter is put in the last section of "KUBE_TEST_ARGS". The last parameter always win, so it actually deprives the option from users to suppress detailed output when running integration test, e.g. running a 5000nodes scheduler benchmark test.

This PR moves --alsologtostderr=true to the head of "KUBE_TEST_ARGS", so that user can overwrite this option (via "KUBE_TEST_ARGS" in command line) to genereate a clean output if they want:

make test-integration WHAT=./test/integration/scheduler_perf KUBE_TEST_VMODULE="''" KUBE_TEST_ARGS="-run=xxx -bench=BenchmarkScheduling -alsologtostderr=false -logtostderr=false"

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

give users the option to suppress detailed output in integration test
@fejta
Copy link
Contributor

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 3, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing and removed needs-sig labels Apr 3, 2019

@Huang-Wei

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 658c290 into kubernetes:master Apr 3, 2019

17 checks passed

cla/linuxfoundation Huang-Wei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@Huang-Wei Huang-Wei deleted the Huang-Wei:option-clean-stdout branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.