Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCE/Windows: disable stackdriver logging agent #76099

Merged
merged 1 commit into from Apr 4, 2019

Conversation

@yujuhong
Copy link
Member

commented Apr 3, 2019

The logging service could not be stopped at times, causing node startup
failures. Disable it until the issue is fixed.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

GCE/Windows: disable stackdriver logging agent to prevent node startup failures
GCE/Windows: disable stackdriver logging agent
The logging service could not be stopped at times, causing node startup
failures. Disable it until the issue is fixed.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pjh

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 3, 2019

@k8s-ci-robot k8s-ci-robot merged commit 3e71348 into kubernetes:master Apr 4, 2019

17 checks passed

cla/linuxfoundation yujuhong authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@tpepper

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Which part of testgrid (https://testgrid.k8s.io/sig-windows ?) would cover this patch? I'm slightly concerned it might break some test case, yet we don't have a master-blocking or 1.14-blocking windows test that I know of, so I'm wondering where to watch to gauge its readiness for backport to 1.14 branch as per #76100

@yujuhong

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

@tpepper this one: https://testgrid.k8s.io/sig-windows#gce-windows-1.14

We don't really have tests running for stackdriver logging yet, so no test will/should be affected. Stackdriver logging agent is causing the occasional cluster bringup failure you can see in the test job, and the PR fixes that.

@yujuhong

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

@tpepper this one: https://testgrid.k8s.io/sig-windows#gce-windows-1.14

Oops, that one runs against the 1.14 branch.
This is the job against the master: https://testgrid.k8s.io/sig-windows#gce-windows-master
It hasn't had any cluster bringup failure since the PR has been merged.

@tpepper

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

Sounds good, thanks for the additional context @yujuhong!

k8s-ci-robot added a commit that referenced this pull request Apr 5, 2019

Merge pull request #76100 from yujuhong/automated-cherry-pick-of-#760…
…99-upstream-release-1.14

Automated cherry pick of #76099: GCE/Windows: disable stackdriver logging agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.