Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
GCE/Windows: disable stackdriver logging agent #76099
The logging service could not be stopped at times, causing node startup
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Apr 3, 2019
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yujuhong
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
referenced this pull request
Apr 3, 2019
Apr 4, 2019
17 checks passed
Which part of testgrid (https://testgrid.k8s.io/sig-windows ?) would cover this patch? I'm slightly concerned it might break some test case, yet we don't have a master-blocking or 1.14-blocking windows test that I know of, so I'm wondering where to watch to gauge its readiness for backport to 1.14 branch as per #76100
We don't really have tests running for stackdriver logging yet, so no test will/should be affected. Stackdriver logging agent is causing the occasional cluster bringup failure you can see in the test job, and the PR fixes that.
Oops, that one runs against the 1.14 branch.