Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emptry array expansion error in cluster/gce/util.sh #76111

Merged
merged 1 commit into from Apr 5, 2019

Conversation

@kewu1992
Copy link
Contributor

commented Apr 4, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
It fixes a bug in cluster/gce/util.sh that empty array expansion causes "unbound variable" error in
bash 4.2 and bash 4.3.

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Hi @kewu1992. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kewu1992

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

/cc @yujuhong

@k8s-ci-robot k8s-ci-robot requested a review from yujuhong Apr 4, 2019

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

@kewu1992 thanks for fixing this!
Could you add a release note and a cherry-pick PR as well? We should patch 1.14.

/lgtm
/approve

/cc @pjh @mtaufen

@k8s-ci-robot k8s-ci-robot requested review from mtaufen and pjh Apr 4, 2019

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 4, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kewu1992, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

/ok-to-test

@pjh

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

/lgtm

Thanks @kewu1992!

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

/retest

Fix empty array expansion error in cluster/gce/util.sh
Empty array expansion causes "unbound variable" error in
bash 4.2 and bash 4.3.

@kewu1992 kewu1992 force-pushed the kewu1992:fix_gce_util.sh branch from eeaf5ea to 925dc7f Apr 4, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 4, 2019

@yujuhong

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 4, 2019

@kewu1992

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

Could you add a release note and a cherry-pick PR as well? We should patch 1.14.

Done.

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 5, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 1b1b785 into kubernetes:master Apr 5, 2019

17 checks passed

cla/linuxfoundation kewu1992 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
k8s-ci-robot added a commit that referenced this pull request Apr 5, 2019
Merge pull request #76208 from kewu1992/automated-cherry-pick-of-#761…
…11-upstream-release-1.14

Automated cherry pick of #76111: Fix empty array expansion error in cluster/gce/util.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.