Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRD validation error on 'items' field #76124

Merged
merged 8 commits into from Jun 27, 2019

Conversation

@tossmilestone
Copy link
Contributor

commented Apr 4, 2019

Signed-off-by: He Xiaoxi tossmilestone@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fix CRD validation errror on 'items' field

Which issue(s) this PR fixes:

Fixes #68466

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix CRD validation error on 'items' field.
@caesarxuchao

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

/assign @mbohlool
/cc @apelisse

@k8s-ci-robot k8s-ci-robot requested a review from apelisse Apr 4, 2019
@tossmilestone tossmilestone force-pushed the tossmilestone:fix-crd-validate-items branch from 5333e76 to 16ed9f3 Apr 8, 2019
@tossmilestone

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

/assign @liggitt

@tossmilestone tossmilestone force-pushed the tossmilestone:fix-crd-validate-items branch from 16ed9f3 to 050d4c5 Apr 8, 2019
@tossmilestone tossmilestone force-pushed the tossmilestone:fix-crd-validate-items branch 2 times, most recently from 8dfb907 to 1403ba2 Apr 8, 2019
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
@tossmilestone tossmilestone force-pushed the tossmilestone:fix-crd-validate-items branch from b329280 to 2e37a3b Jun 26, 2019
@tossmilestone

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

@liggitt this PR is done now, PTAL.

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

thanks for the quick update. the dependencies you pulled in have transitive dependencies we need to also bump. hack/lint-dependencies.sh | grep -v golang will show the ones we need to bump. Go ahead and put all the openapi ones in a single commit, and the others in their own commits.

Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
@tossmilestone

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

@liggitt all bumps are done, please check again.

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 27, 2019
@@ -349,9 +303,15 @@ func (s *Schema) AddType(tpe, format string) *Schema {
return s
}

// AsNullable flags this schema as nullable.
func (s *Schema) AsNullable() *Schema {

This comment has been minimized.

Copy link
@liggitt

liggitt Jun 27, 2019

Member

@sttts, fyi that we picked up a version with this

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

@tossmilestone, thanks for all the work on this

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tossmilestone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Jun 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1a80962 into kubernetes:master Jun 27, 2019
23 checks passed
23 checks passed
cla/linuxfoundation tossmilestone authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@cliveseldon

This comment has been minimized.

Copy link

commented Oct 11, 2019

Unfortunately this fix has not solved the core issue. See go-openapi/validate#108
This has gone into k8s 1.16 and causes the k8sapi-server to panic. I will try to raise a bug issue for this to fully document. @liggitt

@cliveseldon

This comment has been minimized.

Copy link

commented Oct 11, 2019

On further investigation I think this is due to x-kubernetes-int-or-string

See #83778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.