Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a simple release-note builder that scrapes the Github API for recent PRs #7616

Merged
merged 3 commits into from May 7, 2015

Conversation

Projects
None yet
3 participants
@brendandburns
Copy link
Contributor

commented May 1, 2015

@roberthbailey

Closes #6213

Possibly worth automating further, but this will help standardize and organize.

@googlebot googlebot added the cla: yes label May 1, 2015

@roberthbailey roberthbailey self-assigned this May 1, 2015

GOPATH=$PWD go get github.com/google/go-querystring
GOPATH=$PWD go build release-notes.go

./release-notes --laste-release-pr=<pr # of the previous release>

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey May 1, 2015

Member

should be "last-release-pr"

@@ -0,0 +1,71 @@
/*
Copyright 2014 Google Inc. All rights reserved.

This comment has been minimized.

Copy link
@roberthbailey

This comment has been minimized.

Copy link
@brendandburns

brendandburns May 1, 2015

Author Contributor

done.

"github.com/google/go-github/github"
)

var (

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey May 1, 2015

Member

you don't need a block if there's only one var

This comment has been minimized.

Copy link
@brendandburns

brendandburns May 1, 2015

Author Contributor

done.

opts.Page++
results, _, err := client.PullRequests.List("GoogleCloudPlatform", "kubernetes", &opts)
if err != nil {
fmt.Printf("Error contacting github: %v", err)

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey May 1, 2015

Member

should we exit here? this could easily get lost in the noise of a bunch of PRs and make it easy to miss changes

This comment has been minimized.

Copy link
@brendandburns

brendandburns May 1, 2015

Author Contributor

done.

This documents the process for making release notes for a release.

### 1) Note the PR number of the previous release
Find the PR that was merged with the previous release. Remember this number

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey May 1, 2015

Member

It seems like there should be a simple command line that would generate this that we can document here.

This comment has been minimized.

Copy link
@brendandburns

brendandburns May 1, 2015

Author Contributor

Yeah, I could add this, TODO?

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey May 1, 2015

Member

TODO is fine. Just wondering if we needed to add a step to write this down to save the next release engineer a ton of time or if there's an easy way to regenerate it.

This comment has been minimized.

Copy link
@brendandburns

brendandburns May 2, 2015

Author Contributor

Github search works pretty well for this.

This comment has been minimized.

Copy link
@brendandburns

brendandburns May 2, 2015

Author Contributor

TODO added.

### 1) Note the PR number of the previous release
Find the PR that was merged with the previous release. Remember this number

### 2) Build the release-notes tool

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey May 1, 2015

Member

numbers 2/3 here are redundant with the README.md file and one or the other is likely to get out of date (there is already a typo in the README that isn't a typo here).

This comment has been minimized.

Copy link
@brendandburns

brendandburns May 1, 2015

Author Contributor

Refactored into a shell script and referenced in both places.

@brendandburns brendandburns force-pushed the brendandburns:qps branch from 33e65b1 to c3d75f4 May 1, 2015

exit 1
fi

set -o nounset

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey May 1, 2015

Member

please move this to the top and use [[ -z "${1:-}" ]]; in the above check.

This comment has been minimized.

Copy link
@brendandburns

brendandburns May 2, 2015

Author Contributor

done.

GOPATH=$PWD go build release-notes.go
./release-notes --last-release-pr=${1}

popd > /dev/null

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey May 1, 2015

Member

nit: this won't be executed if any of the above commands return a non-zero status.

@roberthbailey

This comment has been minimized.

Copy link
Member

commented May 1, 2015

Travis and shippable are both unhappy with your change, failing trying to install godeps. Maybe you need to bite the bullet now and get the dependencies into our godeps tree....

@brendandburns brendandburns force-pushed the brendandburns:qps branch 5 times, most recently from 223228a to fce355f May 2, 2015

brendandburns added some commits May 1, 2015

@brendandburns brendandburns force-pushed the brendandburns:qps branch from fce355f to 5ab20b8 May 7, 2015

@brendandburns brendandburns force-pushed the brendandburns:qps branch from 5ab20b8 to 1375a18 May 7, 2015

@brendandburns

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2015

@roberthbailey does this look good to merge? Shippable failure is a flake.

@roberthbailey

This comment has been minimized.

Copy link
Member

commented May 7, 2015

Yes. LGTM.

roberthbailey added a commit that referenced this pull request May 7, 2015

Merge pull request #7616 from brendandburns/qps
Adds a simple release-note builder that scrapes the Github API for recent PRs

@roberthbailey roberthbailey merged commit e5b9f74 into kubernetes:master May 7, 2015

3 of 4 checks passed

Shippable Builds timed-out on Shippable
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 48.73%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.