Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dep-approvers for reviewing go dependency changes #76198

Merged
merged 1 commit into from Apr 6, 2019

Conversation

@cblecker
Copy link
Member

cblecker commented Apr 5, 2019

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add dep-approvers for reviewing go dependency changes

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
# dep-approvers
"go\\.(mod|sum)$":
required_reviewers:
- kubernetes/dep-approvers

This comment has been minimized.

Copy link
@nikhita

nikhita Apr 5, 2019

Member

Does this work for github teams?

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 5, 2019

Author Member

Yup :)

This comment has been minimized.

Copy link
@nikhita

nikhita Apr 5, 2019

Member

Nice!

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Apr 5, 2019

I guess...
/sig release

/priority important-soon

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 5, 2019

/sig release
/priority important-soon

@k8s-ci-robot k8s-ci-robot requested review from brendandburns and liggitt Apr 5, 2019

@nikhita

nikhita approved these changes Apr 5, 2019

Copy link
Member

nikhita left a comment

/lgtm

/assign @liggitt
for approval

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Apr 6, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b8d2aa0 into kubernetes:master Apr 6, 2019

17 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:dep-review branch Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.