Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate SupportNodePidsLimit to beta #76221

Merged
merged 1 commit into from May 6, 2019

Conversation

@RobertKrawitz
Copy link
Contributor

commented Apr 5, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This graduates process ID limiting for nodes (#73651) to beta, per plan.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

As of Kubernetes 1.15, the SupportNodePidsLimit feature introduced as alpha in Kubernetes 1.14 is now beta, and the ability to utilize it is enabled by default.  It is no longer necessary to set the feature gate `SupportNodePidsLimit=true`.  In all other respects, this functionality behaves as it did in Kubernetes 1.14.
@RobertKrawitz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@k8s-ci-robot k8s-ci-robot requested a review from derekwaynecarr Apr 5, 2019

@RobertKrawitz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

/cc @dashpole

@k8s-ci-robot k8s-ci-robot requested a review from dashpole Apr 5, 2019

@RobertKrawitz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

/retest

@k8s-ci-robot k8s-ci-robot added kind/feature and removed needs-kind labels Apr 9, 2019

@dashpole

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

/lgtm

For a little more context, this feature gate is specifically for allowing pid=X to be set in kube-reserved and system-reserved. This sets the pid limit for the allocatable cgroup when the feature gate is enabled. But this will only actually limit pids when the pid=X is added to kube-reserved or system reserved.

@RobertKrawitz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

@derekwaynecarr

This comment has been minimized.

Copy link
Member

commented May 6, 2019

/approve

testing back in 1.14 was sufficient, and node allocatable is a well tested feature area.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, RobertKrawitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 922f360 into kubernetes:master May 6, 2019

18 checks passed

cla/linuxfoundation RobertKrawitz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Context retired. Status moved to "pull-kubernetes-dependencies".
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@RobertKrawitz RobertKrawitz deleted the RobertKrawitz:node-pid-limit-beta branch May 7, 2019

@RobertKrawitz RobertKrawitz referenced this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.