Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of dependency script cleanups #76244

Merged
merged 2 commits into from Apr 12, 2019

Conversation

@cblecker
Copy link
Member

cblecker commented Apr 7, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Cleans up some leftover script stuff after the move to go modules.

Does this PR introduce a user-facing change?:

NONE

cblecker added some commits Apr 7, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 7, 2019

/priority backlog
/sig release

@@ -48,8 +48,6 @@ fi
# Exclude vendor checks in certain cases, if they're running in a separate job.
if [[ ${EXCLUDE_GODEP:-} =~ ^[yY]$ ]]; then
EXCLUDED_PATTERNS+=(
"verify-godeps.sh" # runs in separate godeps job
"verify-godeps-licenses.sh" # runs in separate godeps job

This comment has been minimized.

Copy link
@liggitt

liggitt Apr 7, 2019

Member

these are still needed as long as kubernetes/test-infra#12045 is unresolved. the only reason the verify-godeps CI job is green on this PR is because of #76094

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 7, 2019

Author Member

You're right, this shouldn't be merged until kubernetes/test-infra#12104 is.

@@ -21,15 +21,6 @@ set -o pipefail
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
source "${KUBE_ROOT}/hack/lib/init.sh"

readonly branch=${1:-${KUBE_VERIFY_GIT_BRANCH:-master}}
if ! [[ ${KUBE_FORCE_VERIFY_CHECKS:-} =~ ^[yY]$ ]] && \

This comment has been minimized.

Copy link
@liggitt

liggitt Apr 7, 2019

Member

are we just dropping these since the job runs faster now?

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 7, 2019

Author Member

Yup! This logic was fragile (only worked if you had a full clone of the repo). With the 3-5 min run time, we can just run this 100% of the time.

@@ -21,29 +21,16 @@ set -o pipefail
KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
source "${KUBE_ROOT}/hack/lib/init.sh"

readonly branch=${1:-${KUBE_VERIFY_GIT_BRANCH:-master}}

This comment has been minimized.

Copy link
@liggitt

liggitt Apr 7, 2019

Member

are we just dropping these since the job runs faster now?

This comment has been minimized.

Copy link
@cblecker

cblecker Apr 7, 2019

Author Member

same as above

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 7, 2019

/hold

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 11, 2019

/hold cancel

This should be good to go, @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Apr 11, 2019

/test pull-kubernetes-dependencies

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 11, 2019

@liggitt Passing :)

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Apr 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 11, 2019

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Apr 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 28d5023 into kubernetes:master Apr 12, 2019

18 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Context retired. Status moved to "pull-kubernetes-dependencies".
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:dep-script-fixups branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.